[PATCH] D60464: [pstl] Setup the _PSTL_VERSION macro like _LIBCPP_VERSION, and add release notes

Thomas Rodgers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 12 11:07:31 PDT 2019


rodgert added a comment.

In D60464#1464545 <https://reviews.llvm.org/D60464#1464545>, @ldionne wrote:

> It's implicit in C++. I mean we can decide to do it like the rest of libc++, but we don't have to. For libc++, the reasoning is that it's needed to test in a freestanding environment.
>
> @rodgert @MikeDvorskiy Do you guys want to consistently use `return 0;` at the end of `main`? If so, I'll fix this (and any other test that doesn't do it).


I do it out of habit (because I'm old and wrote C before C++ was really a thing you could use seriously) but I don't have a strong opinion either way on this.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60464/new/

https://reviews.llvm.org/D60464





More information about the llvm-commits mailing list