[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 12 09:17:59 PDT 2019


compnerd added inline comments.


================
Comment at: lld/ELF/InputFiles.cpp:662
   }
+  case SHT_LLVM_DEPLIBS: {
+    if (Config->Relocatable)
----------------
Can you make the flag here reflect the name as well?  (`SHT_LLVM_DEPENDENT_LIBRARIES`)


================
Comment at: lld/ELF/Options.td:74
 
+defm deplibs: B<"deplibs",
+    "Process dependent library specifiers from input files (default)",
----------------
I think that I prefer the `--dependent-libraries` flag which is similar to the recent additions to the linker options.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60274/new/

https://reviews.llvm.org/D60274





More information about the llvm-commits mailing list