[PATCH] D60614: [llvm-readelf] Fix dumping of SHN_XINDEX symbols

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Okay, basically looks fine. Just a couple of small comments.



================
Comment at: test/tools/llvm-readobj/many-sections2.s:1
+# REQUIRES: x86-registered-target
+# RUN: llvm-mc %s -filetype=obj -triple=x86_64-pc-linux -o %t
----------------
A brief comment at the start of test describing what this test is testing might help future readers.


================
Comment at: test/tools/llvm-readobj/many-sections2.s:20
+# CHECK:     65278: 0000000000000000 0 NOTYPE GLOBAL DEFAULT 65280 sym_65277
+# CHECK-NOT: PRC
+# CHECK:     65310: 0000000000000000 0 NOTYPE GLOBAL DEFAULT 65312 sym_65309
----------------
Actually, with the positive CHECKS, I don't think you need the negative ones.


================
Comment at: test/tools/llvm-readobj/many-sections2.s:25
+# CHECK-NOT: RSV
+
----------------
Nit: Too many blank lines at EOF?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60614/new/

https://reviews.llvm.org/D60614