[PATCH] D60614: [llvm-readelf] Fix dumping of SHN_XINDEX symbols

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 12 07:15:53 PDT 2019


jhenderson added inline comments.


================
Comment at: test/tools/llvm-readobj/many-sections2.s:1
+# RUN: llvm-mc %s -filetype=obj -triple=x86_64-pc-linux -o %t
+# RUN: llvm-readelf -s %t | FileCheck %s
----------------
You'll need a `REQUIRES: x86` line


================
Comment at: test/tools/llvm-readobj/many-sections2.s:22
+
+# CHECK-NOT: PRC
----------------
As well as the CHECK-NOT, it's also probably worth checking that the values in the reserved range are printed as regular values.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60614/new/

https://reviews.llvm.org/D60614





More information about the llvm-commits mailing list