[PATCH] D60614: [llvm-readelf] Fix dumping of SHN_XINDEX symbols

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 12 07:01:47 PDT 2019


jhenderson added a comment.

> There is no test for PRC, OS and RSV kind of symbols. Does anyone know how to generate them?

Use yaml2obj, with an explicit section index, but actually you don't need to test them as they are already tested by test/tools/llvm-readobj/elf-symbol-shndx.test.



================
Comment at: test/tools/llvm-readobj/many-sections.test:1
+# RUN: llvm-mc %s -filetype=obj -o %t
+# RUN: llvm-readelf -s %t | FileCheck %s
----------------
Won't this generate COFF output on Windows hosts? I think you need to specify a target triple, and probably a REQUIRES: x86 or similar.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60614/new/

https://reviews.llvm.org/D60614





More information about the llvm-commits mailing list