[PATCH] D60381: FileCheck [1/12]: Move variable table in new object
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 12 06:32:43 PDT 2019
jhenderson added inline comments.
================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:44
+ EXPECT_FALSE(LocalVar);
+ EXPECT_TRUE(GlobalVar);
+}
----------------
jhenderson wrote:
> I would add one last check to this test: re-add a local variable and show that you can fetch it again.
Okay, just waiting for this point to be addressed before I LGTM this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60381/new/
https://reviews.llvm.org/D60381
More information about the llvm-commits
mailing list