[PATCH] D60383: FileCheck [3/12]: Stricter parsing of @LINE expressions

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/lib/Support/FileCheck.cpp:67
+/// it.
+static char next(StringRef &s) {
+  char c = s.front();
----------------
I'd use normal comments not doxygen for a small static helper like this.


================
Comment at: llvm/lib/Support/FileCheck.cpp:75
+/// string corresponding to the operation being performed in \p Trailer.
+/// Return whether parsing failed in which case errors are reported on \p SM.
+bool FileCheckPattern::parseExpression(StringRef Name, StringRef Trailer,
----------------
Please put doxygen for new APIs in the header not the implementation file.  (Eventually the doxygen for all the methods should be in the header, but that's for a later cleanup.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60383/new/

https://reviews.llvm.org/D60383