[PATCH] D60382: FileCheck [2/12]: Stricter parsing of -D option
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 12 06:20:06 PDT 2019
probinson added a comment.
Wouldn't it be preferable to put the command-line option validation in the driver, rather than here?
The division of responsibilities between the driver and the library is really not clear-cut; normally I'd expect the driver to do option parsing/validation and the library to simply accept the list. (I understand that FileCheck currently isn't always organized that way, but it's something I'd like to see happen.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60382/new/
https://reviews.llvm.org/D60382
More information about the llvm-commits
mailing list