[PATCH] D60589: [sanitizer_common] Expose a variadic version of the sanitizer Printf function.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 11 18:24:06 PDT 2019


eugenis added a comment.

Is this meant as a test-only thing?
I don't think we want sanitizer Printf anywhere close to production.

IMHO, we could use printf() in gwpasan directly, with a guard against recursive malloc.



================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_common.h:25
 
+#include <stdarg.h>
+
----------------
kcc wrote:
> No, please don't include any system headers here. 
> Will need to find some other way. 
stdarg could be fine...




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60589/new/

https://reviews.llvm.org/D60589





More information about the llvm-commits mailing list