[PATCH] D60495: Load balancing for LTO

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: lib/LTO/LTO.cpp:1305
+  // modules in terms of decreasing size to provide better compile-time
+  // load-balance.
+  using ModuleMapElt = std::pair<StringRef, BitcodeModule>;
----------------
The ThinLink has access to much fine grain data: like number of function and number of instructions. Have you looked into using this?



================
Comment at: lib/LTO/LTO.cpp:1316
+                     Right.second->second.getBuffer().size();
+            });
+
----------------
FYI: https://github.com/llvm/llvm-project/blob/master/llvm/lib/LTO/ThinLTOCodeGenerator.cpp#L923

I used a separate index vector in ThinLTOCodeGenerator to do the same, it may make the code a bit easier to track (less pair<> and `.first->second` kind of thing).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60495/new/

https://reviews.llvm.org/D60495