[PATCH] D59514: [PGO] Profile guided code size optimization.

[Hiroshi Yamauchi via Phabricator via llvm-commits]

yamauchi marked 3 inline comments as done.
yamauchi added inline comments.


================
Comment at: test/Transforms/ConstantHoisting/ARM/const-addr-no-neg-offset.ll:3
+; RUN: opt -mtriple=arm-arm-none-eabi -consthoist -pgso -S < %s | FileCheck %s -check-prefix=PGSO
+; RUN: opt -mtriple=arm-arm-none-eabi -consthoist -pgso=false -S < %s | FileCheck %s -check-prefix=NPGSO
 
----------------
eraman wrote:
> You don't need a separate run with explicit -pgso=false. You can use the first run and use CHECK and CHECK-LABEL where you use NPGSO and NPGO-LABEL . That's what I had in mind, but if you prefer this, it's fine.
Sure. I think separate runs are probably better in that it doesn't matter what the default value of -pgso is.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59514/new/

https://reviews.llvm.org/D59514