[PATCH] D60549: [LLD][COFF] use offset in archive to disambiguate archive members

[Bob Haarman via Phabricator via llvm-commits]

inglorion marked an inline comment as done.
inglorion added inline comments.


================
Comment at: lld/COFF/InputFiles.h:298
 public:
-  explicit BitcodeFile(MemoryBufferRef M) : InputFile(BitcodeKind, M) {}
+  BitcodeFile(MemoryBufferRef MB) : BitcodeFile(MB, "", 0) {}
+  BitcodeFile(MemoryBufferRef MB, StringRef ArchiveName,
----------------
ruiu wrote:
> Do you still need this ctor?
Alternatively, I could do without this constructor; there is just one call site where I would have to specify the parameters. I liked the constructor version a bit better because it doesn't end up with a bunch of parameters whose meaning is hard to deduce at the call site. I'm happy to go with whichever version you like better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60549/new/

https://reviews.llvm.org/D60549