[PATCH] D60479: [MemorySSA] Small fix for the clobber limit.

George Burgess IV via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 11 14:00:11 PDT 2019


george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

LGTM after a nit is addressed. Thanks!



================
Comment at: lib/Analysis/MemorySSA.cpp:553
+    if (!*UpwardWalkLimit) {
+      ++*UpwardWalkLimit;
+      LimitAlreadyReached = true;
----------------
For clarity's sake, can we please explicitly `= 1` here (and `= 0` in the new conditional below), rather than incrementing/decrementing?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60479/new/

https://reviews.llvm.org/D60479





More information about the llvm-commits mailing list