[PATCH] D60387: FileCheck [7/12]: Arbitrary long numeric expressions

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Support/FileCheck.cpp:65-66
 llvm::Optional<uint64_t> FileCheckASTBinop::eval() const {
-  llvm::Optional<uint64_t> OptOpl = Opl->getValue();
-  // Variable has been undefined.
+  llvm::Optional<uint64_t> OptOpl = Opl->eval();
+  llvm::Optional<uint64_t> OptOpr = Opr->eval();
+
----------------
I would capitalize the L/R at the end


================
Comment at: llvm/lib/Support/FileCheck.cpp:69-72
   if (!OptOpl.hasValue())
     return llvm::None;
-  return EvalBinop(OptOpl.getValue(), Opr);
+  if (!OptOpr.hasValue())
+    return llvm::None;
----------------
Can merge these into !L || !R


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60387/new/

https://reviews.llvm.org/D60387