[PATCH] D59973: [SLP] Refactoring of the operand reordering code.

[Vasileios Porpodas via Phabricator via llvm-commits]

vporpo added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:736
+  public:
+    VLOperands() = default;
+    /// Initialize with all the operands of the instruction vector \p VL.
----------------
ABataev wrote:
> Seems to me, this constructor is not used.  Transform it into `deleted` rather than `default`.
It is used by OpsVec.resize() so I can't delete it.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:975
+    /// \returns the number of operands.
+    unsigned getNumOperands() const { return OpsVec.size(); }
+
----------------
ABataev wrote:
> Private?
I guess we can keep everything private for now except reorder() and getVL()


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59973/new/

https://reviews.llvm.org/D59973