[PATCH] D60522: [KnownBits] Add computeForAddCarry()

[Nikita Popov via Phabricator via llvm-commits]

nikic marked an inline comment as done.
nikic added a subscriber: craig.topper.
nikic added inline comments.


================
Comment at: llvm/lib/Support/KnownBits.cpp:35
   APInt CarryKnownUnion = std::move(CarryKnownZero) | CarryKnownOne;
   APInt Known = std::move(LHSKnownUnion) & RHSKnownUnion & CarryKnownUnion;
 
----------------
RKSimon wrote:
> Are we gaining much from using the std::move? It reduces grokability and in most cases we'll be dealing with APInts representing i64 or less so its not heap allocated.
The use of `std::move()` in this code was introduced as part of D36433. Maybe @craig.topper could comment?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60522/new/

https://reviews.llvm.org/D60522