[PATCH] D60556: [DebugInfo at O2] Fix pr41175 Dead Store Elimination missing debug loc

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/Transforms/DeadStoreElimination/memset-missing-debugloc.ll:5
+; RUN: opt -S -march=native -dse < %s| FileCheck %s
+; CHECK: bitcast [5 x i64]* %{{[a-zA-Z_][a-zA-Z0-9_]*}} to i8*, !dbg !16
+; CHECK: %{{[0-9]+}} = getelementptr inbounds i8, i8* %0, i64 32, !dbg ![[DBG:[0-9]+]]
----------------
is the `!16` necessary? Hardcoded numbers are bound to break sooner or later.


================
Comment at: llvm/test/Transforms/DeadStoreElimination/memset-missing-debugloc.ll:6
+; CHECK: bitcast [5 x i64]* %{{[a-zA-Z_][a-zA-Z0-9_]*}} to i8*, !dbg !16
+; CHECK: %{{[0-9]+}} = getelementptr inbounds i8, i8* %0, i64 32, !dbg ![[DBG:[0-9]+]]
+; CHECK: ![[DBG]] = !DILocation(line: 2,
----------------
CHECK-NEXT?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60556/new/

https://reviews.llvm.org/D60556