[PATCH] D60564: Changes for LLVM PPCISelLowering function combineBVOfConsecutiveLoads

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 11 06:42:31 PDT 2019


hfinkel added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:12110
 
-  assert(!(InputsAreConsecutiveLoads && InputsAreReverseConsecutive) &&
+  assert((InputsAreConsecutiveLoads && InputsAreReverseConsecutive) &&
          "The loads cannot be both consecutive and reverse consecutive.");
----------------
You put || in the description, but this still says &&. Did you mean ||?


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:12111
+  assert((InputsAreConsecutiveLoads && InputsAreReverseConsecutive) &&
          "The loads cannot be both consecutive and reverse consecutive.");
 
----------------
This text needs to be updated too?



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60564/new/

https://reviews.llvm.org/D60564





More information about the llvm-commits mailing list