[PATCH] D60294: [DAGCombiner] [CodeGenPrepare] WIP/RFC Splitting large offsets from base addresses

Thu Apr 11 06:30:41 PDT 2019

asb added a comment.

In D60294#1462628 <https://reviews.llvm.org/D60294#1462628>, @spatel wrote:

> Not sure if it's relevant to what this patch is trying to do, but x86 has a similar example described here:
>  https://bugs.llvm.org/show_bug.cgi?id=24447

Thanks for the link. This has the potential to help in the case that the large constants were produced by `getelementptr`s. Except the logic here and in CodeGenPrepare's splitgep routines checks isLegalAddressingMode, which may not be selective enough for X86 given its addressing modes are so unrestricted.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60294/new/

https://reviews.llvm.org/D60294