[PATCH] D59535: [SelectionDAG] Compute known bits of CopyFromReg

Thu Apr 11 05:47:40 PDT 2019

lebedev.ri added a comment.

In D59535#1461651 <https://reviews.llvm.org/D59535#1461651>, @dmgreen wrote:

> Thanks. I've reverted in r358113 and will attempt to add some extra tests in.

Yes, **please** add tests (ideally for x86 too.).

>> We need a test for each of these cases. Otherwise we risk having the same problem all over again.
> 
> Definitely agree.
> 
> I guess this is something that will be fixed in global isel. In the meantime, perhaps we could do with something that is more specific about not being visible though, more than just a bitcast.  Happy to help if I can, just let me know.

D60294 <https://reviews.llvm.org/D60294> caught my attention, that may be a //related// fix.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59535/new/

https://reviews.llvm.org/D59535