[PATCH] D60411: Filter out irrelevant llvm-nm option

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 11 05:20:24 PDT 2019


jhenderson added inline comments.


================
Comment at: test/tools/llvm-nm/help.test:1
+RUN: llvm-nm -help 2>&1 | FileCheck %s
+CHECK: Generic Options:
----------------
jhenderson wrote:
> Do an `--implicit-check-not="General Options:"` here to show that we don't have the old options. I'd also use --help, rather than -help, since that is closer to the norm.
I'd be surprised if this test passed currently...! The --implicit-check-not command should be for FileCheck: https://llvm.org/docs/CommandGuide/FileCheck.html


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60411/new/

https://reviews.llvm.org/D60411





More information about the llvm-commits mailing list