[PATCH] D60401: [llvm-exegesis] When generating templates with chained instructions, also add templates for helper instructions

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 11 04:53:16 PDT 2019


lebedev.ri marked an inline comment as done.
lebedev.ri added inline comments.


================
Comment at: unittests/tools/llvm-exegesis/X86/SnippetGeneratorTest.cpp:213
+    // IT0: PrimaryInstruction0[, SecondaryInstruction0[, ...]]
+    // IT1: PrimaryInstruction1(==SecondaryInstruction0)[, ...]
+    // ...
----------------
gchatelet wrote:
> I don't understand this second line.
Line 2 says that while PrimaryInstruction1 is the primary instruction in that snippet,
that PrimaryInstruction1 is the same instruction as SecondaryInstruction0.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60401/new/

https://reviews.llvm.org/D60401





More information about the llvm-commits mailing list