[PATCH] D60554: Fix number of args of prof branch_weights MD for SwitchInst

Yevgeny Rouban via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 11 04:09:39 PDT 2019


yrouban marked an inline comment as done.
yrouban added inline comments.


================
Comment at: llvm/test/Transforms/SimpleLoopUnswitch/trivial-unswitch.ll:1247
+
+; CHECK: ![[MD0]] = !{!"branch_weights", i32 99, i32 1, i32 2}
----------------
As the default branch is changed it must expect !{!"branch_weights", i32 4, i32 1, i32 2} but the test passes because of a bug in SimpleLoopUnswitch. I'm fixing it and will provide one more patch. For this case I can change all weights to 1s as I did for SimpleLoopUnswitch/basictest.ll above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60554/new/

https://reviews.llvm.org/D60554





More information about the llvm-commits mailing list