[PATCH] D60502: [llvm-nm] Add --special-syms

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-nm/X86/nm-no-symbols.test:1
 # RUN: yaml2obj %s > %t.o
 # RUN: llvm-nm %t.o 2>&1 | FileCheck %s
----------------
This is a test for testing llvm-nm's ability to handle no symbols in the output. You shouldn't test --special-syms here unless it is somehow special for no symbols. You should add it as a new test separately.


================
Comment at: test/tools/llvm-nm/X86/nm-no-symbols.test:5
 
+# Check that --special-syms doesn't trigger error
+# RUN: llvm-nm --special-syms %t.o 2>&1 | FileCheck %s
----------------
"error" -> "an error."


================
Comment at: tools/llvm-nm/llvm-nm.cpp:168
+cl::opt<bool> SpecialSyms("special-syms",
+                          cl::desc("No-op. Used for GNU compatibility only"));
+
----------------
What does --special-syms do in GNU nm?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60502/new/

https://reviews.llvm.org/D60502