[PATCH] D60555: [llvm-objcopy] Fill .symtab_shndx section correctly

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 11 02:46:22 PDT 2019


jhenderson added a comment.

In D60555#1462406 <https://reviews.llvm.org/D60555#1462406>, @evgeny777 wrote:

> > Test case?
>
> Have you seen bug description?
>  The problem with test case is that it requires file with large number of sections of which at least some should have relocation sections. 
>  I have 19Mb object file generated by clang, but I'm not sure if using it as test case is a good idea ...


Sorry, I skipped over that somehow (I think I jumped straight from the bug). We already have at least one test that uses many sections (see many-sections.test). That unzips a pre-built object to achieve this. One option might be to update that object file (and possibly the test), if it can satisfy the prerequisites you need.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60555/new/

https://reviews.llvm.org/D60555





More information about the llvm-commits mailing list