[PATCH] D60411: Filter out irrelevant llvm-nm option

Thu Apr 11 02:43:50 PDT 2019

jhenderson added a comment.

In D60411#1461905 <https://reviews.llvm.org/D60411#1461905>, @serge-sans-paille wrote:

> Question: instead of having -s require two argument, we could require one argument and split on space character, or comma?

Splitting on a character would make a lot of sense. Most tools use '=' or similar for multi-string arguments. However, if there is a Mach-O version of llvm-nm that inspired this option, we should be compatible with that if at all possible.

================
Comment at: test/tools/llvm-nm/help.test:1
+RUN: llvm-nm -help 2>&1 | FileCheck %s
+CHECK: Generic Options:
----------------
Do an `--implicit-check-not="General Options:"` here to show that we don't have the old options. I'd also use --help, rather than -help, since that is closer to the norm.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60411/new/

https://reviews.llvm.org/D60411