[PATCH] D60470: [DWARF] Prefer larger DW_AT_low_pc when constructing aranges

Thu Apr 11 02:20:35 PDT 2019

jhenderson added a comment.

In D60470#1462002 <https://reviews.llvm.org/D60470#1462002>, @dblaikie wrote:

> In D60470#1460670 <https://reviews.llvm.org/D60470#1460670>, @MaskRay wrote:
>
> > > What does addr2line (or any other symbolizers, not that I know of others) do in these cases?
> >
> > addr2line doesn't use binary search. It iterates all ELF sections, finds the first section containing the address, then iterates DWARF CUs and finds the associated line table. It has the same problem
>
>
> Any idea why this problem hasn't been much of an issue until now/recently (both your change here, and the LLD change being reviewed)?

It's not even a new issue. We've had this problem for years in the PlayStation proprietary linker, because ASLR-enabled executables have a 0 base address. We have special handling of discarded functions to work around this in the linker.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60470/new/

https://reviews.llvm.org/D60470