[PATCH] D60549: [LLD][COFF] use offset in archive to disambiguate archive members

Bob Haarman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 10 17:33:29 PDT 2019


inglorion created this revision.
inglorion added reviewers: pcc, mehdi_amini, ruiu.
Herald added subscribers: dexonsmith, steven_wu, eraman.
Herald added a project: LLVM.

Archives can contain multiple members with the same name. This would
cause ThinLTO links to fail ("Expected at most one ThinLTO module per
bitcode file"). This change implements the same strategy we use in
the ELF linker: make the offset in the archive part of the module
name so that names are unique.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60549

Files:
  lld/COFF/Driver.cpp
  lld/COFF/Driver.h
  lld/COFF/InputFiles.cpp
  lld/COFF/InputFiles.h
  lld/test/COFF/thinlto-archivecollision.ll
  lld/test/COFF/thinlto-archives.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60549.194617.patch
Type: text/x-patch
Size: 6909 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190411/7ad85380/attachment.bin>


More information about the llvm-commits mailing list