[PATCH] D60534: [AArch64][GlobalISel] Legalization and ISel support for load/stores of vectors of pointers
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 10 15:29:44 PDT 2019
aemerson marked an inline comment as done.
aemerson added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64LegalizerInfo.cpp:218-220
+ {v2s32, p0, 64, 8},
+ {v2s64, p0, 128, 8}})
// These extends are also legal
----------------
arsenm wrote:
> The downside of this is it now breaks any non-0 address pointers, where before they would just work. You might want to add another case for arbitrary address spaces
Not sure what you mean, how does this break non-zero addrspace pointers? This legalization rule only applies to the 0 addrspace p0 type.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60534/new/
https://reviews.llvm.org/D60534
More information about the llvm-commits
mailing list