[PATCH] D59348: [DebugInfo] Combine Trivial and NonTrivial flags

Wed Apr 10 14:35:07 PDT 2019

dblaikie added a subscriber: aprantl.
dblaikie added inline comments.

================
Comment at: include/llvm/IR/DebugInfoFlags.def:57-60
+HANDLE_DI_FLAG((1 << 26), NonTrivial)
 HANDLE_DI_FLAG((1 << 27), BigEndian)
 HANDLE_DI_FLAG((1 << 28), LittleEndian)
 HANDLE_DI_FLAG((1 << 29), AllCallsDescribed)
----------------
@aprantl - could you review this for bitcode compatibility?

I  imagine reusing a bit for a different meaning (the exact opposite) would be problematic?

Would we have to settle for keeping the bitcode encoding as 1=trivial 0=nontrivial (only for structs/classes? Maybe enums too?) - or burn the 26th bit and keep the 30th bit as NonTrivial?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59348/new/

https://reviews.llvm.org/D59348