[PATCH] D60532: [X86] Teach foldMaskedShiftToScaledMask to look throw an any_extend from i32 to i64 between the and & shl

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - thanks!



================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:1389
+
+  // We have an any_extend feeding the AND, look through it to see if there
+  // is a shift behind. But only if the AND doesn't use the extended bits.
----------------
We have -> If we have


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:1391
+  // is a shift behind. But only if the AND doesn't use the extended bits.
+  // FIXME: Generalize this behind i32.
+  bool FoundAnyExtend = false;
----------------
behind -> beside?


================
Comment at: llvm/test/CodeGen/X86/fold-and-shift-x86_64.ll:79
 
 ; FIXME should be able to fold shift into address.
 define i8 @t6(i8* %X, i32 %i) {
----------------
Remove stale comment


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60532/new/

https://reviews.llvm.org/D60532