[PATCH] D60522: [KnownBits] Add computeForAddCarry()

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 10 12:38:21 PDT 2019


lebedev.ri added inline comments.


================
Comment at: llvm/lib/Support/KnownBits.cpp:20-21
+    const KnownBits &LHS, const KnownBits &RHS,
+    bool CarryZero, bool CarryOne) {
+  assert(!(CarryZero && CarryOne) &&
+         "Carry can't be zero and one at the same time");
----------------
How about simply making it `KnownBits(/*KnownBits=*/1)` ?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60522/new/

https://reviews.llvm.org/D60522





More information about the llvm-commits mailing list