[PATCH] D59535: [SelectionDAG] Compute known bits of CopyFromReg

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 10 11:11:42 PDT 2019


dmgreen added a comment.

Thanks. I've reverted in r358113 and will attempt to add some extra tests in.

> We need a test for each of these cases. Otherwise we risk having the same problem all over again.

Definitely agree.

I guess this is something that will be fixed in global isel. In the meantime, perhaps we could do with something that is more specific about not being visible though, more than just a bitcast.  Happy to help if I can, just let me know.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59535/new/

https://reviews.llvm.org/D59535





More information about the llvm-commits mailing list