[llvm] r358102 - add FIXME: as per echristo
Nick Desaulniers via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 10 09:38:44 PDT 2019
Author: nickdesaulniers
Date: Wed Apr 10 09:38:44 2019
New Revision: 358102
URL: http://llvm.org/viewvc/llvm-project?rev=358102&view=rev
Log:
add FIXME: as per echristo
Modified:
llvm/trunk/include/llvm/CodeGen/MachineInstr.h
Modified: llvm/trunk/include/llvm/CodeGen/MachineInstr.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/MachineInstr.h?rev=358102&r1=358101&r2=358102&view=diff
==============================================================================
--- llvm/trunk/include/llvm/CodeGen/MachineInstr.h (original)
+++ llvm/trunk/include/llvm/CodeGen/MachineInstr.h Wed Apr 10 09:38:44 2019
@@ -1016,6 +1016,8 @@ public:
getOpcode() == TargetOpcode::INLINEASM_BR;
}
+ /// FIXME: Seems like a layering violation that the AsmDialect, which is X86
+ /// specific, be attached to a generic MachineInstr.
bool isMSInlineAsm() const {
return isInlineAsm() && getInlineAsmDialect() == InlineAsm::AD_Intel;
}
More information about the llvm-commits
mailing list