[PATCH] D60381: FileCheck [1/12]: Move variable table in new object

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre updated this revision to Diff 194507.
thopre marked 5 inline comments as done.
thopre added a comment.

- Make context a shared_ptr
- Don't use auto for parameter of foreach loop if collection is not a local variable
- Fix usage of Optional objects
- Remove void function parameter
- Remove references to pattern variable, be it in comment or identifiers
- Fix ie -> i.e. typo


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60381/new/

https://reviews.llvm.org/D60381

Files:
  llvm/include/llvm/Support/FileCheck.h
  llvm/lib/Support/FileCheck.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60381.194507.patch
Type: text/x-patch
Size: 24819 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190410/aafd0dde/attachment.bin>