[llvm] r358079 - [llvm-exegesis] Pacify bots - don't std::move() - prevents copy elision

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 10 05:47:47 PDT 2019


Author: lebedevri
Date: Wed Apr 10 05:47:47 2019
New Revision: 358079

URL: http://llvm.org/viewvc/llvm-project?rev=358079&view=rev
Log:
[llvm-exegesis] Pacify bots - don't std::move() - prevents copy elision

Modified:
    llvm/trunk/tools/llvm-exegesis/lib/BenchmarkResult.cpp

Modified: llvm/trunk/tools/llvm-exegesis/lib/BenchmarkResult.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-exegesis/lib/BenchmarkResult.cpp?rev=358079&r1=358078&r2=358079&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-exegesis/lib/BenchmarkResult.cpp (original)
+++ llvm/trunk/tools/llvm-exegesis/lib/BenchmarkResult.cpp Wed Apr 10 05:47:47 2019
@@ -392,7 +392,7 @@ llvm::Error InstructionBenchmark::writeY
                                             const llvm::StringRef Filename) {
   if (Filename == "-") {
     if (auto Err = writeYamlTo(State, llvm::outs()))
-      return std::move(Err);
+      return Err;
   } else {
     int ResultFD = 0;
     if (auto E = llvm::errorCodeToError(
@@ -402,7 +402,7 @@ llvm::Error InstructionBenchmark::writeY
     }
     llvm::raw_fd_ostream Ostr(ResultFD, true /*shouldClose*/);
     if (auto Err = writeYamlTo(State, Ostr))
-      return std::move(Err);
+      return Err;
   }
   return llvm::Error::success();
 }




More information about the llvm-commits mailing list