[PATCH] D60411: Filter out irrelevant llvm-nm option

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I don't think a test for every option is wise, but could you paste the output of the help text with your change applied, please, so I can review it easily?



================
Comment at: tools/llvm-nm/llvm-nm.cpp:62
 cl::list<std::string> InputFilenames(cl::Positional, cl::desc("<input files>"),
-                                     cl::ZeroOrMore);
+                                     cl::ZeroOrMore, cl::cat(NMCat));
 
----------------
I've not experimented with this, but do you need to put a category for the positional arguments?


================
Comment at: tools/llvm-nm/llvm-nm.cpp:101
 cl::alias Portability("portability", cl::desc("Alias for --format=posix"),
-                      cl::aliasopt(POSIXFormat), cl::NotHidden);
+                      cl::aliasopt(POSIXFormat), cl::NotHidden, cl::cat(NMCat));
 cl::opt<bool> DarwinFormat("m", cl::desc("Alias for --format=darwin"),
----------------
Do aliases need a category or do they inherit their base one?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60411/new/

https://reviews.llvm.org/D60411