[PATCH] D59535: [SelectionDAG] Compute known bits of CopyFromReg

Piotr Sobczak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 10 02:33:10 PDT 2019


piotr added a comment.

It's indeed unfortunate that you saw a regression with my patch. The patch makes SelectionDAG see more context, so it provides more optimization opportunities. Arguably, the fact that you see worse code now is a limitation of the optimization you mentioned that has become visible only now. Have you checked whether the problematic opt could be restricted (possibly only on targets not benefiting from the broader scope of the SelectionDAG)?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59535/new/

https://reviews.llvm.org/D59535





More information about the llvm-commits mailing list