[PATCH] D60488: [AsmPrinter] refactor to remove remove AsmVariant. NFC

[Yuanfang Chen via Phabricator via llvm-commits]

tabloid.adroit added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp:444
             if (InlineAsm::isMemKind(OpFlags)) {
-              Error = AP->PrintAsmMemoryOperand(MI, OpNo, InlineAsmVariant,
-                                                Modifier[0] ? Modifier : nullptr,
----------------
craig.topper wrote:
> It doesn't make sense to me that we were passing InlineAsmVariant(which should always be AT&T) here. Shouldn't we be passing the PrinterAsmVariant? If the printer is set to Intel syntax and we expand dialects from curly braces assuming that. Then we should also print operands using Intel syntax. And then tell the MC layer that what it needs to parse is Intel syntax.
I think this is related to PR23933 (which I'm actively working on) and PR24232. I will submit a review for PR23933 very soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60488/new/

https://reviews.llvm.org/D60488