[PATCH] D60488: [AsmPrinter] refactor to remove remove AsmVariant. NFC
Eric Christopher via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 9 15:13:45 PDT 2019
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
One inline comment for a future cleanup, otherwise LGTM and thanks!
-eric
================
Comment at: llvm/lib/Target/X86/X86AsmPrinter.cpp:230
const MachineOperand &MO = MI->getOperand(OpNo);
+ const bool IsATT = MI->getInlineAsmDialect() == InlineAsm::AD_ATT;
switch (MO.getType()) {
----------------
... you can get it on the MI? That seems like the wrong level :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60488/new/
https://reviews.llvm.org/D60488
More information about the llvm-commits
mailing list