[PATCH] D60227: [Remarks] Add string deduplication using a string table

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM with the outstanding comments/questions addressed.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1365
+  // just use the serialize function with a raw_ostream because of the way
+  // MCStreamers work.
+  const remarks::StringTable &StrTab = RS->getStringTable();
----------------
Can you be more specific? Could we write everything but the version to a buffer and EmitBinaryData here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60227/new/

https://reviews.llvm.org/D60227