[PATCH] D60474: [llvm] [lit] Add target-x86 feature

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 10 01:09:13 PDT 2019


mgorny marked 2 inline comments as done.
mgorny added inline comments.


================
Comment at: llvm/utils/lit/lit/llvm/config.py:100
+            # target is using x86 family processor (32- or 64-bit)
+            if re.match(r'^x86.*', target_triple):
+                features.add('target-x86')
----------------
craig.topper wrote:
> Don't 32-bit x86 triples use i386 or i686 rather than "x86"?
Yes, you are correct. I don't know what I was thinking yesterday but I'll also split it into x86/x86_64 as well whle at it..


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60474/new/

https://reviews.llvm.org/D60474





More information about the llvm-commits mailing list