[PATCH] D60364: [DWARF] Set discriminator to 0 for DW_LNS_copy

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 9 19:28:00 PDT 2019


MaskRay added a comment.

In D60364#1460434 <https://reviews.llvm.org/D60364#1460434>, @dblaikie wrote:

> Should there also be an LLVM test - given that LLVM does emit DW_LNS_copy by the looks of it, and if it's been being incorrectly interpreted/dumped, then that seems to imply there's some missing LLVM test coverage for that case, maybe?


Do you mean a test of `lib/MC/MCDwarf.cpp`? As I understand it, `lib/DebugInfo/DWARF` is mostly the reader part and `MC` the writer part. With my casual reading, `MCDwarf.cpp` seems to do the correct thing by doing `Discriminator = 0;`. I haven't looked into that part yet but I can investigate that and add a test if needed in a separate change.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60364/new/

https://reviews.llvm.org/D60364





More information about the llvm-commits mailing list