[PATCH] D60395: [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y)

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 9 19:06:18 PDT 2019


shchenz added a comment.

In D60395#1460248 <https://reviews.llvm.org/D60395#1460248>, @lebedev.ri wrote:

> @shchenz how did rL358017 <https://reviews.llvm.org/rL358017> end up committing this diff into completely different place in this function?


Sorry, my bad. My remote dev machine is very slow yesterday night so I did not do a `make check-all` test before I committed the code. And I didn't reliaze that git merges my code into a wrong place in file `lib/Transforms/InstCombine/InstCombineMulDivRem.cpp` which was also changed by other patch yesterday.

I will send out another patch later.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60395/new/

https://reviews.llvm.org/D60395





More information about the llvm-commits mailing list