[PATCH] D60481: [LLVM-C] Add Bindings to Access an Instruction's DebugLoc

Robert Widmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 9 14:59:48 PDT 2019


CodaFi marked an inline comment as done.
CodaFi added inline comments.


================
Comment at: llvm/include/llvm-c/DebugInfo.h:1206
+ * To clear the location metadata of the given instruction, pass NULL to \p Loc.
+ * The debug location is consumed by this function if it is non-NULL.
+ *
----------------
whitequark wrote:
> What does "consumed" mean here exactly? Aren't metadata owned by the context anyway?
Whoops, I read the std::move in the accessor and figured it would steal the data from the tracking ref.  But it appears that is not the case.  I'll update this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60481/new/

https://reviews.llvm.org/D60481





More information about the llvm-commits mailing list