[PATCH] D60460: [SelectionDAG] Let computeKnownBits handle OR-like ADDs better

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 9 13:28:14 PDT 2019


lebedev.ri added a comment.

In D60460#1460375 <https://reviews.llvm.org/D60460#1460375>, @nikic wrote:

> We have an accurate known bits implementation for adds in `KnownBits::computeForAddSub()`, which should handle this and more automatically. We use it to compute add known bits in IR. Is there a reason why it's not used for SDAG known bits?


Hmm, good point. In general because of IR `Value` vs DAG `SDValue`. But clearly that function should work here..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60460/new/

https://reviews.llvm.org/D60460





More information about the llvm-commits mailing list