[PATCH] D60457: [CodeGen] Fixed de-optimization of legalize subvector extract

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 9 12:37:24 PDT 2019


efriedma added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:4066
 
+  if (VT.isVector()) {
+    EVT EltVT = VT.getVectorElementType();
----------------
So if I'm following this correctly, this takes a cast like `<12 x i8>` -> `<3 x i32>`, and turns it into `<16 x i8>` -> `<4 x i32>`?  That makes sense, but please add a comment describing it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60457/new/

https://reviews.llvm.org/D60457





More information about the llvm-commits mailing list