[PATCH] D60156: [X86] Use FILD/FIST to implement i64 atomic load on 32-bit targets with X87, but no SSE2

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 9 12:12:57 PDT 2019


craig.topper marked an inline comment as done.
craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:27431
+        // integer into the significand.
+        // FIXME: Do we need to glue?
+        SDVTList Tys = DAG.getVTList(MVT::f80, MVT::Other, MVT::Glue);
----------------
RKSimon wrote:
> Do we?
I based that on the similar sequence in X86TargetLowering::BuildFILD. Wasn't sure if the FIXME there was still relevant.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60156/new/

https://reviews.llvm.org/D60156





More information about the llvm-commits mailing list