[PATCH] D52239: [OCaml] Add OCaml APIs to access DebugLoc info
Robert Widmann via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 9 11:31:06 PDT 2019
CodaFi added a comment.
My concern is that we’re building parallel API hierarchies here. The old hat way of wrapping metadata nodes in a value and casting out to an LLVMValueRef makes no sense if we have APIs to manipulate metadata more directly.
LLVMDILocationGetLine, LLVMDILocationGetColumn, LLVMDILocationGetScope should do what you want, and we should be building accessors for file and directory information on top of those bindings instead of the old LLVMValueRef ones.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D52239/new/
https://reviews.llvm.org/D52239
More information about the llvm-commits
mailing list