[PATCH] D60376: [llvm-objdump] Align instructions to a tab stop and accept (and ignore) -w/--wide

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 9 11:25:44 PDT 2019


rupprecht added a comment.

I'm fine with the `-w` flag, but I haven't had time to look at tab alignment code -- it seems very hard to follow. Perhaps it should be a separate patch? This seems like two unrelated changes.



================
Comment at: test/tools/llvm-objdump/X86/disassemble-align.s:2
+# RUN: llvm-mc -filetype=obj -triple=x86_64 %s | \
+# RUN:   llvm-objdump -d -print-imm-hex - | sed 'y/\t/ /' | FileCheck -strict-whitespace %s
+
----------------
You can include literal tabs in tests
In some editors it is ctrl+v, then tab


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60376/new/

https://reviews.llvm.org/D60376





More information about the llvm-commits mailing list